@jamill @ethomson @yorah If you feel like giving a peek at it, that would be awesome 😉

Duh. Travis failed.

I may have broken Fetch()...

👍

Thanks to @ethomson Travis is now happy with libgit2/libgit2#1947.

Despite the Proxy.git_branch_iterator() being really ugly, I've merged this. Once we get more iterators bound, maybe @dahlbyk will agree to sprinkle some of his refactoring magic 😉

Despite the Proxy.git_branch_iterator() being really ugly, I've merged this.

That may be our highest cyclomatic complexity yet! ✨

@dahlbyk will agree to sprinkle some of his refactoring magic

Put me in, coach. Too lazy to check - are other such iterators already implemented?

are other such iterators already implemented?

Not yet. I was scared of them. @carlosmn forced me with libgit2/libgit2#1938 and I hate him for this 😉

I'm starting to think that maybe we could simplify the Diff.Compare<T> code by relying on the iterators rather than on the callbacks. @yorah any thought about this?